Hi Stuart,

[snip]
>  /* visit rc files in order */
>  /* Changed by SDB 1.2.2005 in response to Peter Kaiser's bug report.
>   * Read gafrc files first */
>  found_rc |= g_rc_parse_system_rc("gafrc");
>  found_rc |= g_rc_parse_home_rc("gafrc");
>  found_rc |= g_rc_parse_local_rc("gafrc");
>  /* continue support for individual rc files for each program.  */
>  found_rc |= g_rc_parse_system_rc(rcname);
>  found_rc |= g_rc_parse_home_rc(rcname);
>  found_rc |= g_rc_parse_local_rc(rcname);
[snip]

        I would rather have the order like this:

  /* visit rc files in order */
  found_rc |= g_rc_parse_system_rc(rcname);
  found_rc |= g_rc_parse_home_rc(rcname);
  found_rc |= g_rc_parse_home_rc("gafrc");
  found_rc |= g_rc_parse_local_rc(rcname);
  found_rc |= g_rc_parse_gaf_rc(); 

        
        I think the gafrc files should be read after the existing rc
files, but in this order: system-wide, user-wide, local.

        I think that will satisfiy the request to search for ~/.gEDA/gafrc.
I really don't see a need for a system-gafrc since there already exists
a system-commonrc.


[snip]
>1.  Can you think of any reason why this shouldn't be done this way?
>I found that in the event that no gafrc lives anywhere, the program
>complains, but doesn't do anything bad.  However, I want to make sure
>I am not doing something foolish.


        Sounds like a reasonable request.  I didn't add a search for
~/.gEDA/gafrc since I didn't think it was needed, but I was wrong. 


>2.  Ales, assuming this change is OK, what is your policy w.r.t. folks
>checking stuff into libgeda & other CVS respositories.  Would you
>prefer to review it first, or should I just go ahead and check it in?
>If you don't mind, I may just go into libgeda and make some other
>changes too, but I don't want to cause any problems or step on any
>toes.

        Go right ahead and make the changes.  I'll review the changes
when I update. :)

                                                                -Ales

Reply via email to