On Wed, 5 Nov 2008 00:01:36 +0100
Klaus Ethgen <[EMAIL PROTECTED]> wrote:
> Am Di den 4. Nov 2008 um 18:20 schrieb Laurent MONIN:
> > > 1. A patch to revert commit 1141 as it breaks the build!
> >
> > No way to decompress this one.
>
> Hmmm.. I did send it uncompressed but the mailing list was holding it
> back. So I include it to that mail again.
>
I don't see the point of this patch, code was disabled and a FIXME added because
it wasn't equivalent to older code.
Omari Stephens proposed a fix in its message "Two patches: fix segfault, and
update deprecated GTK API calls".
It has to be tested.
> > > 2. A change of the debugging method that allow selecting the debugging
> > > level with binary selection.
> > > 3. This patch is basing on number 2. It is introducing that every (well,
> > > nearly, see the patch note) function call can be printed with debug
> > > leven 5 (32).
> >
> > I'm unsure about these patches. Vladimir, what are you thinking about those
> > ?
>
> Not more I had expected. :-) Well, it is a big change but only for
> debugging. I found it very useful to find out what is exactly done.
> However, I am not unhappy if it will not find the way in the repository.
> But at least the information about the functions I left out cause of
> many calls can be used to improve geeqie.
>
Things can be simpler: just use __FUNCTION__ instead of a different
message in each function.
For example, instead of DEBUG_5("Entering function help_window_show()");
something like DEBUG_F();
with
#define DEBUG_F() DEBUG_5("%s", __FUNCTION__)
--
Laurent MONIN aka Zas
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geeqie-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
