-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Mi den 5. Nov 2008 um 8:25 schrieb Laurent MONIN:
> I don't see the point of this patch, code was disabled and a FIXME added
> because
> it wasn't equivalent to older code.
> Omari Stephens proposed a fix in its message "Two patches: fix segfault, and
> update deprecated GTK API calls".
> It has to be tested.
Well, the buggy patch did just replace "#if GTK_CHECK_VERSION(2,12,0)"
with "#if 0" so that the first function is never used and only the
second is used. But in GTK+ > 2.12.0 the function
gtk_tree_view_tree_to_widget_coords() is not available but
gtk_tree_view_convert_bin_window_to_widget_coords() works well so with
the "#if 0" there is no way to link together the code as there is no
such function.
Beside of that, the functions might be different but to disable a
compilable version completely is no solution for that.
> Things can be simpler: just use __FUNCTION__ instead of a different
> message in each function.
Nice. I did search for that. :) How was that with the tree and the
forest!? Well, as I did not insert the debugging calls by hand there was
no problem for me searching for __FUNCTION__ as it takes simply no more
work to add the function name.
> For example, instead of DEBUG_5("Entering function help_window_show()");
> something like DEBUG_F();
> with
> #define DEBUG_F() DEBUG_5("%s", __FUNCTION__)
I Agree.
Regards
Klaus Ethgen
- --
Klaus Ethgen http://www.ethgen.de/
pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <[EMAIL PROTECTED]>
Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iQEVAwUBSRFUf5+OKpjRpO3lAQLyrQf/bp5yz10JoY3jend5OFqNSnYybmHXEZrL
teEqQMl7ixWAbTtvYVRJ/NOlEaWkysIjV5uYpupTKqb983sLDZKKdffbLYDdwfPz
oPTLiE/p/2ukuwCKC8VwGQULPk+Sw84dgmdJ8uGDGyKjC4X+ZIBwrjRoR2vkNUzM
YKc9YXtyYDJEpxBWn+NuKp7OpGyfHfqtjUC6bdEKKHyIm4BZkpyQ1PmgqQUBiYX7
xvP5ZuCz9XubGOHy6KHlAX3p62gYKIGuJ8gllazYgQV2kqeFtsssA0lpz0uN5/R1
MGPrf8JBBkLFdCUmqH3Vz/g5UozTC5wfbuRolQzmWsNKHhLPaeqWdQ==
=Yums
-----END PGP SIGNATURE-----
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
