- I forgot to say that I know it's not 'docoxygenated' yet. I will do with
all functions that I 'understand' and those wich are mine.

- This is commented in pan_fullscreen_toggle_image function.If I do:

   ImageWindow *imd = g_new(ImageWindow,1);

should I do g_free(imd) after?


2009/6/8 Oscar Miras <oscar.mi...@gmail.com>

> Hi all,
>
> I'm sending my first patch to you. It enables full screen of an image in
> any pan view mode.
> I want to know if it fits geeqie programing style; and I want to know if I
> have made the patch correctly. :)
>
> This patch basically enables full screen of a clicked image in pan view
> mode ( until now, you only could enter full screen pan view mode ).
> Let's say:
>
> #Full screen mode: Pan view full screen mode ( no scrollbars , mouse
> navigation , etc. ).
> #Full screen image mode: You see a single image in the screen ( as in
> geeqie normal view).
>
> - If a pic is clicked; you can enter fullscreen mode with Return key.
> - You can also enter fullscreen image mode when you do right mouse click on
> a pic ( it will appear a new menu option).
> - While you're viewing an image in full screen image mode; you can
> manipulate it ( alter, zoom , copy, etc.)
> - Once you've finished viewing a single image on full screen mode; you can
> exit either by right mouse menu option, or pressing Return key again.
> - Usual ways of returning from pan view full screen mode to pan view normal
> mode; will also finish full screen image mode ( for exameple, if you're in
> full screen image mode, and press ESC; full screen image mode will end).
>
> *Know bugs,missing features,questions*
>
> * To pass from "full screen mode" to "full screen image mode" ; first I
> must return to pan view normal mode and then go to full screen image mode;
> so the image "blinks" a little. I'm sure that with a little bit of more
> coding this blink could be avoided.
>
> * It has not been very tested; i'll do in next days if you like the patch.
> If someone tests it; comments will be very welcome.
>
> *Possible improvements*
>
> + : Start slideshow as in geeqie normal mode from selected pic of selected
> day .
>
>
>
> I'm not working much more on pan view because I want to make pan-calendar
> with clutter.
> I hope next week I'll be able to send you something about this!
>
> Regards,
> Oscar.
>
>
>
>
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to