On Monday 08 June 2009 18:51:07 Laurent Monin wrote: > Oscar Miras a écrit : > > - I forgot to say that I know it's not 'docoxygenated' yet. I will do > > with all functions that I 'understand' and those wich are mine. > > > > - This is commented in pan_fullscreen_toggle_image function.If I do: > > > > ImageWindow *imd = g_new(ImageWindow,1); > > > > should I do g_free(imd) after? > > Yes. > See > http://library.gnome.org/devel/glib/stable/glib-Memory-Allocation.html#g-ne >w >
But you should not need this. ImageWindow should be created with image_new() and destroyed when the corresponding pixbuf renderer gets "destroy" signal. This happens typically when the window is closed. The fullscreen_start takes content of an existing windowed ImageWindow and copies it to newly created fullscreen ImageWindow. In pan view, there is no existing ImageWindow, but creating a temporary one is probably not a good idea because of the overhead. Maybe it would be better to extend the fullscreen_start function to work with NULL imd argument. It probably needs only some "if (fs->normal_imd)" conditions in fullscreen.c. Then you can work only with fs_image->imd in pan view, for image_change_fd and similar functions. Vladimir ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
