Yuriy Kaminskiy a e'crit :
Hello!
   Due to missing assignment to start_index and end_index, monospace
attribute did not applied to label, causing constant resizing of that
field (I've also grepped for pango_attr_list_new - other places were ok).
Hi Yuriy,

in recent versions this doesn't seem to be needed (though i may be wrong here).

Pango documentation at http://library.gnome.org/devel/pango/stable/pango-Text-Attributes.html
tells:

/"The PangoAttribute structure represents the common portions of all attributes. Particular types of attributes include this structure as their initial portion. The common portion of the attribute holds the range to which the value in the type-specific part of the attribute applies and should be initialized using pango_attribute_init(). By default an attribute will have an all-inclusive range of [0,G_MAXUINT]."

/Since 1.20, pango_attribute_init() was added.
It would be better to test for Pango versions and provide the fix only for versions that need it.
Also note that indexes are of unsigned type (so G_MAXINT -> G_MAXUINT).

Please provide an improved patch so we can apply it to trunk asap.

Whatever thanks for the report ;)


--

Regards,

Zas
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to