Yuriy Kaminskiy a e'crit :
> Laurent Monin wrote:
>
>> in recent versions this doesn't seem to be needed (though i may be
>> wrong here).
>>
> Well, I just wanted to ask myself "what did pango devs smoke, not using
> that by default".
>
Yes, i agree.
> FWIW, I'm on debian oldstable/etch, with prehistoric pango 1.14.10 ;-)
>
Ok.
>> /Since 1.20, pango_attribute_init() was added.
>> It would be better to test for Pango versions and provide the fix only
>> for versions that need it.
>>
> Not sure.
> 1) No sense to change it only here. And adding ifdefs everywhere will
> clutter code. Make helper macro? Eww.
>
Finally, i tend to agree.
> 2) Not perfectly good as compile-time check (imagine someone build
> binary with 1.20 and run with 1.18? that won't be catched by runtime
> linker), and making that runtime check is complete waste.
> I think better would be add note somewhere to TODO "remove all
> ->{start,end}_index after we will be incompatible with pango < 1.20 for
> other reasons".
>
Convinced.
>> Also note that indexes are of unsigned type (so G_MAXINT -> G_MAXUINT).
>>
> It was G_MAXINT in all other places, so for sake of consistency I've
> preferred to use G_MAXINT too (and that would be really bug only other
> way round).
>
Nm.
>> Please provide an improved patch so we can apply it to trunk asap.
>>
> Anyway, some fugly attempt at that attached.
> Only checked on 1.14, may misbehave on 1.16 or 1.20+, someone should check.
>
Just provide your first patch with a good comment and TODO section
related to modify code at some time.
Thanks a lot for your contribution.
Regards,
---
Zas
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
