Geeqie has several bashisms which seem unnecessary. I don't use all these features so perhaps one or more of the scripts does actually need bash. If it does, it should be found via configure and listed as an explicit dependency. My experience has been that 95% of scripts that say /bin/bash work fine with /bin/sh and I don't see any bash extensions in use here.
Index: plugins/ufraw/geeqie-ufraw
===================================================================
--- plugins/ufraw/geeqie-ufraw (revision 1803)
+++ plugins/ufraw/geeqie-ufraw (working copy)
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
# FIXME TODO:
# improve the default ufraw configuration
Index: plugins/import/geeqie-import
===================================================================
--- plugins/import/geeqie-import (revision 1803)
+++ plugins/import/geeqie-import (working copy)
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
case "$1" in
gqview)
Index: plugins/rotate/geeqie-rotate
===================================================================
--- plugins/rotate/geeqie-rotate (revision 1803)
+++ plugins/rotate/geeqie-rotate (working copy)
@@ -1,8 +1,10 @@
-#!/bin/bash -x
+#!/bin/sh
# This is a helper script that rotate image files according to the metadata
# requirements: ImageMagick, exiftran, exiv2
+set -x
+
GQ_METADATA_DIR="$HOME/.local/share/geeqie/metadata"
rotate()
Index: configure.in
===================================================================
--- configure.in (revision 1803)
+++ configure.in (working copy)
@@ -79,7 +79,7 @@
if test "x${enable_debug_flags}" != "xno"
then
- if test "x${enable_developer}" == "xyes"
+ if test "x${enable_developer}" = "xyes"
then
CXXFLAGS="${CXXFLAGS} -Wall"
CFLAGS="${CFLAGS} -Wstrict-prototypes -Wall"
@@ -342,7 +342,7 @@
AC_HELP_STRING([--enable-gps], [enable GPS map support - experimental]),
[libgps=$enableval], [libgps=auto])
-if test "x${libgps}" == "xyes"; then
+if test "x${libgps}" = "xyes"; then
PKG_CHECK_MODULES(LIBCHAMPLAIN, [champlain-0.3 >= 0.3],
[
HAVE_LIBCHAMPLAIN=yes
@@ -356,7 +356,7 @@
HAVE_LIBCHAMPLAIN=disabled
fi
-if test "x${libgps}" == "xyes"; then
+if test "x${libgps}" = "xyes"; then
PKG_CHECK_MODULES(LIBCHAMPLAIN_GTK, [champlain-gtk-0.3 >= 0.3],
[
HAVE_LIBCHAMPLAIN_GTK=yes
pgpuGscjLTeFW.pgp
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
