-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

Am Mi den  9. Jul 2014 um  7:08 schrieb Ian Zimmerman:
> Hi, I hit upon what seems to be at least an infelicity, and perhaps an
> outright bug.  The Copy Path popup menu item calls back this code:
> 
>       clipboard = gtk_clipboard_get(GDK_SELECTION_PRIMARY);
>       gtk_clipboard_set_text(clipboard, g_shell_quote(fd->path), -1);
> 
> But, according to the GTK documentation:
> 
>   The currently-selected object or text should be provided on the
>   clipboard identified by GDK_SELECTION_PRIMARY. Cut/copy/paste menu
>   items conceptually copy the contents of the GDK_SELECTION_PRIMARY
>   clipboard to the default clipboard, i.e. they copy the selection to
>   what the user sees as the clipboard.

So?

> So, the above code should really use GDK_SELECTION_CLIPBOARD.

In your pasted text it is always called about GDK_SELECTION_PRIMARY. and
never about GDK_SELECTION_CLIPBOARD. But it might be possible that I
miss something there as my English might be not the best. For my
understanding GDK_SELECTION_PRIMARY is the right one.

> This has an unfortunate practical consequence: after copying the path
> this way, I am unable to paste it anywhere in the geeqie UI itself,
> without a roundtrip through some other program like Emacs that
> understands both kinds of selections. (Don't ask why, but creating a
> subdirectory named according to the selected file is part of my
> workflow in some cases).

The problem is that with the current solution, the most used way to copy
around text under unix works, using the middle mouse button. Changing
that might (I did not test it but that might be worth to test) end up in
being unable to paste. Not all consoles knows Strg-V (what comes from
the windows world, I think).

I personally like to be able to copy the path to selection clipboard and
paste it in the terminal where I mostly work. That does not work if I
use Strg-C in some GUIs but it works with Geeqie.

> Can this be fixed?

Well, it can, if it really fixes some and don't break others. It is even
open source. Just make an patch for suggestion. It might get accepted
(or not. :-).

Maybe even copy it to more than one buffer might be ok. (Keep in mind
that in unix there are three different buffers, most of them evolved in
the newer time and not supported by all software. They make fully sens
to copy around other stuff than just simple text.

Regards
   Klaus
- -- 
Klaus Ethgen                              http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen <kl...@ethgen.de>
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQGcBAEBCgAGBQJTvQYxAAoJEKZ8CrGAGfasW4IL/A7jYk6B2bp7jaY9n6QhUu2p
7yt9ZJvfDMlahKgIQpFVHpA6VSNKZe8FqZcVHhmJAedk7u43mtf9j8+mtZGhp7vu
U53vYo22e8DquIn3oGmN1BANXMEzq+HKZAhlt+chRKyJtQSYptJ/7D8nHFMmFxS7
6rn4YtrSqFmWT+enhmfTLtCdCZmTynosOR5WoqJ9yXTp/mlzQjOkk7h6MnmovTkC
KK9PAj+IU7EjVKzM0RRTpFPIdvbHZeKmj/WsG2D+ox7KY6nY9npF2mxiz02KcOGf
ca+ljhgKC0lg4STOrGeIp1+yT76HRuRvGN8dvizEYFh0APwlnZEfYnAigB8cw5sQ
BfstlA3iy6c65ZLmvoDF2lfKzdfFEqZKVdYcS4n9GPsXczGbzaJggb0h0rUY7oSb
vPGE2NJUySQmqFSmLudrCjaqUmtcgBLstyYn2ze6NEE2Pm3wCCndqg4j7YpmCmhZ
owJ23T7TnjY8a0Wv/UI4mpnbQlc5a3yKil5oV2dJew==
=YxsX
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to