> On April 23, 2014, 10:20 p.m., Steve Reinhardt wrote: > > Seems reasonable to me. I'd just fold in the following typemap patch as > > well; not sure we gain anything by keeping them separate. > > > > Don't forget to update the wiki page when this gets committed.
Sure, will do (for both requests). As a side note, the patches were actually created the other way round to fix a swig bug, and it was only afterwards it was clear that fixing it for >= 2.0.4 broke all previous versions. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2229/#review5030 ----------------------------------------------------------- On April 23, 2014, 12:10 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2229/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:10 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10181:942ddbd6695d > --------------------------- > scons: update SCons SWIG version check to 2.0.4 > > > Diffs > ----- > > SConstruct e40b35147270 > > Diff: http://reviews.gem5.org/r/2229/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
