----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2232/#review5033 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 23, 2014, 12:12 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2232/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 12:12 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10184:4dac507c6ab5 > --------------------------- > arm: remove the inline specifiers on the instruction constructors > > With (upcoming) separate compilation, they are useless. Only > link-time optimization could re-inline them, but ideally > feedback-directed optimization would choose to do so only for > profitable (i.e. common) instructions. > > > Diffs > ----- > > src/arch/arm/isa/templates/basic.isa e40b35147270 > src/arch/arm/isa/templates/branch.isa e40b35147270 > src/arch/arm/isa/templates/branch64.isa e40b35147270 > src/arch/arm/isa/templates/data64.isa e40b35147270 > src/arch/arm/isa/templates/mem.isa e40b35147270 > src/arch/arm/isa/templates/mem64.isa e40b35147270 > src/arch/arm/isa/templates/misc.isa e40b35147270 > src/arch/arm/isa/templates/misc64.isa e40b35147270 > src/arch/arm/isa/templates/mult.isa e40b35147270 > src/arch/arm/isa/templates/pred.isa e40b35147270 > src/arch/arm/isa/templates/vfp.isa e40b35147270 > src/arch/arm/isa/templates/vfp64.isa e40b35147270 > > Diff: http://reviews.gem5.org/r/2232/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
