> On April 29, 2014, 6:38 a.m., Nilay Vaish wrote: > > Is it possible write some preprocessing macro that generates both the > > enum and the quoted strings? > > Andrew Bardsley wrote: > It would be desirable to keep enums and string representations in sync > that way, but it's more world-reorganisation than I feel this patch > immediately demands. > > To make things a bit better I've changed the array into a switch > statement so that the order of the enumeration elements no longer matters, > removed flags will cause an error and added flags will at least fall back on > printing their int representations.
I'd prefer to leave it as is, but just put a static_assert in the code that at least fails compilation if something is added in one but not both places. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2254/#review5042 ----------------------------------------------------------- On April 29, 2014, 11:50 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2254/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 11:50 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10204:845943c6f8ad > --------------------------- > cpu: Add flag name printing to StaticInst > > This patch adds a the member function StaticInst::printFlags to allow all > of an instruction's flags to be printed without using the individual > is... member functions or resorting to exposing the 'flags' vector > > > Diffs > ----- > > src/cpu/static_inst.hh e40b35147270 > src/cpu/static_inst.cc e40b35147270 > > Diff: http://reviews.gem5.org/r/2254/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
