-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2259/#review5081
-----------------------------------------------------------


Looks fine to me.

- Nilay Vaish


On April 23, 2014, 12:27 p.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2259/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 12:27 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10211:f638977b7df5
> ---------------------------
> mem: Make DRAM read/write switching less conservative
> 
> This patch changes the read/write event loop to use a single event
> (nextReqEvent), along with a state variable, thus joining the two
> control flows. This change makes it easier to follow the state
> transitions, and control what happens when.
> 
> With the new loop we modify the overly conservative switching times
> such that the write-to-read switch allows bank preparation to happen
> in parallel with the bus turn around. Similarly, the read-to-write
> switch uses the introduced tRTW constraint.
> 
> 
> Diffs
> -----
> 
>   src/mem/DRAMCtrl.py e40b35147270 
>   src/mem/dram_ctrl.hh e40b35147270 
>   src/mem/dram_ctrl.cc e40b35147270 
> 
> Diff: http://reviews.gem5.org/r/2259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to