-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2249/#review5086
-----------------------------------------------------------


If these changes are necessary for the build system to work with the ISA parser 
changes, then they should be integrated into the same patch.

- Steve Reinhardt


On April 23, 2014, 5:23 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2249/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 5:23 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10201:48db8feb6224
> ---------------------------
> arch: support dynamic ISA file generation in per-ISA SConscripts
> 
> For the null ISA, we just provide a dummy inc.d so SCons is never
> compelled to try to generate it. While it seems slightly wrong to have
> anything in src/arch/*/generated (i.e. a non-generated 'generated' file),
> it's by far the simplest solution.
> 
> 
> Diffs
> -----
> 
>   src/arch/alpha/SConscript e40b35147270 
>   src/arch/arm/SConscript e40b35147270 
>   src/arch/mips/SConscript e40b35147270 
>   src/arch/power/SConscript e40b35147270 
>   src/arch/sparc/SConscript e40b35147270 
>   src/arch/x86/SConscript e40b35147270 
> 
> Diff: http://reviews.gem5.org/r/2249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to