changeset 70333502b9b5 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=70333502b9b5
description:
        mem: Extend DRAM row bits from 16 to 32 for larger densities

        This patch extends the DRAM row bits to 32 to support larger density
        memories. Additional checks are also added to ensure the row fits in
        the 32 bits.

diffstat:

 src/mem/dram_ctrl.cc |  7 +++++--
 src/mem/dram_ctrl.hh |  6 +++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diffs (61 lines):

diff -r d2deb51a4abf -r 70333502b9b5 src/mem/dram_ctrl.cc
--- a/src/mem/dram_ctrl.cc      Mon Jun 30 13:50:03 2014 -0400
+++ b/src/mem/dram_ctrl.cc      Mon Jun 30 13:56:01 2014 -0400
@@ -215,7 +215,9 @@
     // channel, respectively
     uint8_t rank;
     uint8_t bank;
-    uint16_t row;
+    // use a 64-bit unsigned during the computations as the row is
+    // always the top bits, and check before creating the DRAMPacket
+    uint64_t row;
 
     // truncate the address to the access granularity
     Addr addr = dramPktAddr / burstSize;
@@ -294,6 +296,7 @@
     assert(rank < ranksPerChannel);
     assert(bank < banksPerRank);
     assert(row < rowsPerBank);
+    assert(row < Bank::NO_ROW);
 
     DPRINTF(DRAM, "Address: %lld Rank %d Bank %d Row %d\n",
             dramPktAddr, rank, bank, row);
@@ -750,7 +753,7 @@
 
 void
 DRAMCtrl::activateBank(Tick act_tick, uint8_t rank, uint8_t bank,
-                       uint16_t row, Bank& bank_ref)
+                       uint32_t row, Bank& bank_ref)
 {
     assert(0 <= rank && rank < ranksPerChannel);
     assert(actTicks[rank].size() == activationLimit);
diff -r d2deb51a4abf -r 70333502b9b5 src/mem/dram_ctrl.hh
--- a/src/mem/dram_ctrl.hh      Mon Jun 30 13:50:03 2014 -0400
+++ b/src/mem/dram_ctrl.hh      Mon Jun 30 13:56:01 2014 -0400
@@ -211,7 +211,7 @@
         /** Will be populated by address decoder */
         const uint8_t rank;
         const uint8_t bank;
-        const uint16_t row;
+        const uint32_t row;
 
         /**
          * Bank id is calculated considering banks in all the ranks
@@ -242,7 +242,7 @@
         Bank& bankRef;
 
         DRAMPacket(PacketPtr _pkt, bool is_read, uint8_t _rank, uint8_t _bank,
-                   uint16_t _row, uint16_t bank_id, Addr _addr,
+                   uint32_t _row, uint16_t bank_id, Addr _addr,
                    unsigned int _size, Bank& bank_ref)
             : entryTime(curTick()), readyTime(curTick()),
               pkt(_pkt), isRead(is_read), rank(_rank), bank(_bank), row(_row),
@@ -394,7 +394,7 @@
      * @param bank_ref Reference to the bank
      */
     void activateBank(Tick act_tick, uint8_t rank, uint8_t bank,
-                      uint16_t row, Bank& bank_ref);
+                      uint32_t row, Bank& bank_ref);
 
     /**
      * Precharge a given bank and also update when the precharge is
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to