-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2329/#review5259
-----------------------------------------------------------

Ship it!


Ship It!

- Nilay Vaish


On Aug. 13, 2014, 12:51 p.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2329/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 12:51 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10289:d6dce14a12a6
> ---------------------------
> base: Replace the internal varargs stuff with C++11 constructs
> 
> We currently use our own home-baked support for type-safe variadic
> functions. This is confusing and somewhat limited (e.g., cprintf only
> supports a limited number of arguments). This changeset converts all
> uses of our internal varargs support to use C++11 variadic macros.
> 
> 
> Diffs
> -----
> 
>   src/arch/generic/debugfaults.hh 79fde1c67ed8 
>   src/arch/x86/bios/intelmp.cc 79fde1c67ed8 
>   src/base/cprintf.hh 79fde1c67ed8 
>   src/base/misc.hh 79fde1c67ed8 
>   src/base/misc.cc 79fde1c67ed8 
>   src/base/trace.hh 79fde1c67ed8 
>   src/base/trace.cc 79fde1c67ed8 
>   src/base/varargs.hh 79fde1c67ed8 
> 
> Diff: http://reviews.gem5.org/r/2329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to