I think your suggestion makes checkpointing very challenging. Ultimately the state of the rngs should be check pointed, and unless we attached them to specific objects that will be next to impossible with the current flow. At least I would not know how to sensibly do it such that the checkpoint is not tied to a specific thread count.
Andreas On 8/20/14, 10:13 PM, "Nilay Vaish" <[email protected]> wrote: >On Wed, 20 Aug 2014, Andreas Hansson wrote: > >> >> >>> On Aug. 20, 2014, 5:06 p.m., Nilay Vaish wrote: >>>> The patch seems fine. I think we should declare rngs to be thread >>>>local >>>> to begin with and have different seeds for each of these rng to avoid >>>>any >>>> correlation. >> >> Agreed. Finding the thread boundaries might be tricky, so I propose we >> create a rng per Sim/MemOjbect and seed it with some form of hash of >>the >> object name. What do you think? >> > >rng per sim object sounds too much, though the state would probably be a >small number of bytes. And then there might be code that is not part of >any sim object but needs random numbers. I suggest we declare >random_mt with __thread annotation, like we do for the curEventQueue >variable. > >-- >Nilay > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
