> On Nov. 30, 2014, 12:36 a.m., Steve Reinhardt wrote:
> >

Your right on both points. I'll break it out in a separate patch, and indeed 
there is a typo in the link. Well spotted.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2537/#review5583
-----------------------------------------------------------


On Nov. 25, 2014, 9:49 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2537/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 9:49 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10585:54ddda0dc920
> ---------------------------
> scons: Ensure dictionary iteration is sorted by key
> 
> This patch adds sorting based on the SimObject name or parameter name
> for all situations where we iterate over dictionaries. This should
> ensure a deterministic and consistent order across the host systems
> and hopefully avoid regression results differing across python
> versions.
> 
> 
> Diffs
> -----
> 
>   SConstruct dd04eb06ad42 
>   src/SConscript dd04eb06ad42 
>   src/python/m5/SimObject.py dd04eb06ad42 
> 
> Diff: http://reviews.gem5.org/r/2537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to