----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2542/#review5630 -----------------------------------------------------------
src/arch/x86/remote_gdb.hh <http://reviews.gem5.org/r/2542/#comment5035> this equation could use a comment src/arch/x86/remote_gdb.hh <http://reviews.gem5.org/r/2542/#comment5032> same here src/arch/x86/remote_gdb.cc <http://reviews.gem5.org/r/2542/#comment5034> Given that these two lines to grab the right comInstEventQueue appear twice here and once in patch 2540, it would be nice to wrap them up in a little helper method on the RemoteGDB object. In fact, adding something like: EventQueue * RemoteGDB::commitQueue() { return context->getCpuPtr()->comInstEventQueue[context->threadId()]; } void RemoteGDB::scheduleCommitEvent(Event *ev, int delta) { EventQueue *eq = commitQueue(); eq->schedule(ev, eq->getCurTick() + delta); } and then doing everything else in terms of these two functions would IMO make the rest of the code much more readable. - Steve Reinhardt On Nov. 25, 2014, 3:48 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2542/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 3:48 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10570:bd9d8c7d2529 > --------------------------- > x86: Implement a remote GDB stub. > > This stub should allow remote debugging of 32 bit and 64 bit targets. Single > stepping seems to work, as do breakpoints, except it seemed that I got control > back a little before I expected to in some cases. That should be looked into. > > I tried this stub on a 64 bit kernel. I haven't verified that it works on a 32 > bit kernel, nor have I verified that it works in SE mode. > > > Diffs > ----- > > src/arch/x86/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > src/arch/x86/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2542/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
