----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2882/#review6544 -----------------------------------------------------------
I'll read more once you respond to my current queries. src/mem/abstract_mem.cc (line 337) <http://reviews.gem5.org/r/2882/#comment5630> Are you moving this because size of the packet would be zero for clean evicts? src/mem/cache/cache_impl.hh (lines 354 - 361) <http://reviews.gem5.org/r/2882/#comment5638> I am surprised by this comment over here. It implies that the cache is dependent on the interconnect behaving in a certain fashion. Why not keep a count of the caches who have the block? src/mem/cache/cache_impl.hh (line 667) <http://reviews.gem5.org/r/2882/#comment5639> Full stop after it. src/mem/coherent_xbar.cc (lines 141 - 146) <http://reviews.gem5.org/r/2882/#comment5631> Can you explain the issue you are referring to? src/mem/coherent_xbar.cc (line 218) <http://reviews.gem5.org/r/2882/#comment5632> Should not this comment also move down? src/mem/packet.hh (line 90) <http://reviews.gem5.org/r/2882/#comment5633> Instead of checking cmd == CleanEvict, should we not have a function isCleanEvict() like we have for other commands? src/mem/packet.cc (line 90) <http://reviews.gem5.org/r/2882/#comment5634> Why CleaEvict is a write request? src/mem/snoop_filter.cc (line 127) <http://reviews.gem5.org/r/2882/#comment5635> No promises. src/mem/snoop_filter.cc (lines 127 - 140) <http://reviews.gem5.org/r/2882/#comment5636> May be add a TODO statement here instead of the current comment. src/mem/snoop_filter.cc (line 185) <http://reviews.gem5.org/r/2882/#comment5637> Is the following check better: assert((cpkt->cmd == MemCmd::Writeback || cpkt->isInvalidate()) == cpkt->needsExclusive()); - Nilay Vaish On June 10, 2015, 7:59 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2882/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 7:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10873:1ca942c89bd6 > --------------------------- > mem: Add clean evicts and overloaded writebacks > > This patch adds eviction notices to the caches, to provide accurate > tracking of cache blocks in snoop filters. We add the CleanEvict > message to the memory heirarchy and use both CleanEvicts and > Writebacks with BLOCK_CACHED flags to propagate notice of clean and > dirty evictions respectively, down the memory hierarchy. Note that the > BLOCK_CACHED flag indicates whether there exist any copies of the > evicted block in the caches above the evicting cache. > > The purpose of the CleanEvict message is to notify snoop filters of > silent evictions in the relevant caches. The CleanEvict message > behaves much like a Writeback. CleanEvict is a write and a request but > unlike a Writeback, CleanEvict does not have data and does not need > exclusive access to the block. The cache generates the CleanEvict > message on a fill resulting in eviction of a clean block. Before > travelling downwards CleanEvict requests generate zero-time snoop > requests to check if the same block is cached in upper levels of the > memory heirarchy. If the block exists, the cache discards the > CleanEvict message. The snoops check the tags, writeback queue and the > MSHRs of upper level caches in a manner similar to snoops generated > from HardPFReqs. Currently CleanEvicts keep travelling towards main > memory unless they encounter the block corresponding to their address > or reach main memory (since we have no well defined point of > serialisation). Main memory simply discards CleanEvict messages. > > We have modified the behavior of Writebacks, such that they generate > snoops to check for the presence of blocks in upper level caches. It > is possible in our current implmentation for a lower level cache to be > writing back a block while a shared copy of the same block exists in > the upper level cache. If the snoops find the same block in upper > level caches, we set the BLOCK_CACHED flag in the Writeback message. > > We have also added logic to account for interaction of other message > types with CleanEvicts waiting in the writeback queue. A simple > example is of a response arriving at a cache removing any CleanEvicts > to the same address from the cache's writeback queue. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh ebb3d0737aa7 > src/mem/cache/prefetch/base.cc ebb3d0737aa7 > src/mem/coherent_xbar.hh ebb3d0737aa7 > src/mem/coherent_xbar.cc ebb3d0737aa7 > src/mem/dram_ctrl.cc ebb3d0737aa7 > src/mem/packet.hh ebb3d0737aa7 > src/mem/packet.cc ebb3d0737aa7 > src/mem/snoop_filter.cc ebb3d0737aa7 > src/mem/abstract_mem.cc ebb3d0737aa7 > src/mem/cache/cache.hh ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2882/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
