> On June 28, 2015, 5:35 p.m., Nilay Vaish wrote: > > Before I read this patch, I would like you to specifically state in the > > patch comment what the purpose of the original command was.
Sure. I've added a sentence. If you need more info than that I'd suggest to check the changeset that added the support. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2885/#review6637 ----------------------------------------------------------- On June 29, 2015, 9:38 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2885/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 9:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10886:66fdc1c6f94f > --------------------------- > mem: Split WriteInvalidateReq into write and invalidate > > WriteInvalidateReq ensures that a whole-line write does not incur the > cost of first doing a read exclusive, only to later overwrite the > data. This patch splits the existing WriteInvalidateReq into a > WriteLineReq, which is done locally, and an InvalidateReq that is sent > out throughout the memory system. The WriteLineReq re-uses the normal > WriteResp. > > The change allows us to better express the difference between the > cache that is performing the write, and the ones that are merely > invalidating. As a consequence, we no longer have to rely on the > isTopLevel flag. Moreover, the actual memory in the system does not > see the intitial write, only the writeback. We were marking the > written line as dirty already, so there is really no need to also push > the write all the way to the memory. > > The overall flow of the write-invalidate operation remains the same, > i.e. the operation is only carried out once the response for the > invalidate comes back. This patch adds the InvalidateResp for this > very reason. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 73d4798871a5 > src/mem/packet.hh 73d4798871a5 > src/mem/packet.cc 73d4798871a5 > src/mem/ruby/system/RubyPort.cc 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2885/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
