-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2884/#review6660
-----------------------------------------------------------


Any comments?

- Andreas Hansson


On June 10, 2015, 7:59 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2884/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 7:59 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10875:42d8aca53c18
> ---------------------------
> mem: Add ReadCleanReq and ReadSharedReq packets
> 
> This patch adds two new read requests packets:
> 
> ReadCleanReq - For a cache to explicitly request clean data. The
> response is thus exclusive or shared, but not owned or modified. The
> read-only caches (see previous patch) use this request type to ensure
> they do not get dirty data.
> 
> ReadSharedReq - We add this to distinguish cache read requests from
> those issued by other masters, such as devices and CPUs. Thus, devices
> use ReadReq, and caches use ReadCleanReq, ReadExReq, or
> ReadSharedReq. For the latter, the response can be any state, shared,
> exclusive, owned or even modified.
> 
> Both ReadCleanReq and ReadSharedReq re-use the normal ReadResp. The
> two transactions are aligned with the emerging cache-coherent TLM
> standard and the AMBA nomenclature.
> 
> With this change, the normal ReadReq should never be used by a cache,
> and is reserved for the actual (non-caching) masters in the system. We
> thus have a way of identifying if a request came from a cache or
> not. The introduction of ReadSharedReq thus removes the need for the
> current isTopLevel hack, and also allows us to stop relying on
> checking the packet size to determine if the source is a cache or
> not. This is fixed in follow-on patches.
> 
> 
> Diffs
> -----
> 
>   src/mem/cache/base.cc ebb3d0737aa7 
>   src/mem/cache/cache_impl.hh ebb3d0737aa7 
>   src/mem/packet.hh ebb3d0737aa7 
>   src/mem/packet.cc ebb3d0737aa7 
> 
> Diff: http://reviews.gem5.org/r/2884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to