----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2883/#review6671 -----------------------------------------------------------
Ship it! I feel like chatty_assert() is kind of a goofy name, but that's a separate issue... (anyone for something short like "assertv()"?) - Steve Reinhardt On June 30, 2015, 10:14 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2883/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 10:14 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10884:3c905b624d7e > --------------------------- > mem: Allow read-only caches and check compliance > > This patch adds a parameter to the BaseCache to enable a read-only > cache, for example for the instruction cache, or table-walker cache > (not for x86). A number of checks are put in place in the code to > ensure a read-only cache does not end up with dirty data. > > A follow-on patch adds suitable read requests to allow a read-only > cache to explicitly ask for clean data. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 73d4798871a5 > tests/configs/base_config.py 73d4798871a5 > tests/configs/x86_generic.py 73d4798871a5 > configs/common/O3_ARM_v7a.py 73d4798871a5 > src/mem/cache/BaseCache.py 73d4798871a5 > src/mem/cache/base.hh 73d4798871a5 > src/mem/cache/base.cc 73d4798871a5 > configs/common/CacheConfig.py 73d4798871a5 > configs/common/Caches.py 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2883/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
