----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3398/#review8105 -----------------------------------------------------------
Ship it! src/mem/ruby/system/Sequencer.cc (line 560) <http://reviews.gem5.org/r/3398/#comment6989> Can you add a comment here as to why isWrite needs to be checked first? - Jason Lowe-Power On March 20, 2016, 1:01 a.m., Marco Elver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3398/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 1:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > ruby: Implement SwapReq support for Ruby memory > > This implements SwapReq for Ruby memory. > > A SwapReq should be treated like a write, except that the response > packet contains the overwritten data. > > Note that, in particular, the conditional checking for isStore/isLoad > needs to be reversed, as a SwapReq is both. > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.cc 5967db4cff04 > > Diff: http://reviews.gem5.org/r/3398/diff/ > > > Testing > ------- > > Quick regressions. > > The workload requiring this feature now works. > > > Thanks, > > Marco Elver > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
