----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3382/#review8112 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On March 16, 2016, 4:40 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3382/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 4:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11373:ee0feec345c0 > --------------------------- > style: Change include sorter to yield one line at a time > > The include sorter class normally yields one string per line and > relies on the caller to merge lines into a block of text separated by > newlines. However, there are cases when this isn't true. This makes > diffing using Python's difflib hard. This changeset updates the > include sorter to never do this and always yield one line at a time. > > Signed-off-by: Andreas Sandberg <[email protected]> > Reviewed-by: Curtis Dunham <[email protected]> > > > Diffs > ----- > > util/sort_includes.py af870035ab6b > > Diff: http://reviews.gem5.org/r/3382/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
