Hello Nikos Nikoleris, Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15736
to review the following change.
Change subject: mem: Add tryTiming suppport to CommMonitor
......................................................................
mem: Add tryTiming suppport to CommMonitor
The CommMonitor did not support tryTiming, which resulted in gem5
panicing if the CommMonitor was used.
With this change, we update the CommMonitor pass through the
tryTiming() calls.
Change-Id: I86810170e5e10a0c5d63af76fc4a6ab70710d2fb
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/mem/comm_monitor.cc
M src/mem/comm_monitor.hh
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/mem/comm_monitor.cc b/src/mem/comm_monitor.cc
index 354f660..223d1cc 100644
--- a/src/mem/comm_monitor.cc
+++ b/src/mem/comm_monitor.cc
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012-2013, 2015 ARM Limited
+ * Copyright (c) 2012-2013, 2015, 2018 ARM Limited
* Copyright (c) 2016 Google Inc.
* Copyright (c) 2017, Centre National de la Recherche Scientifique
* All rights reserved.
@@ -374,6 +374,12 @@
masterPort.sendRetryResp();
}
+bool
+CommMonitor::tryTiming(PacketPtr pkt)
+{
+ return masterPort.tryTiming(pkt);
+}
+
void
CommMonitor::recvRangeChange()
{
diff --git a/src/mem/comm_monitor.hh b/src/mem/comm_monitor.hh
index d27594d..dac7118 100644
--- a/src/mem/comm_monitor.hh
+++ b/src/mem/comm_monitor.hh
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012-2013, 2015 ARM Limited
+ * Copyright (c) 2012-2013, 2015, 2018 ARM Limited
* Copyright (c) 2016 Google Inc.
* Copyright (c) 2017, Centre National de la Recherche Scientifique
* All rights reserved.
@@ -232,6 +232,11 @@
mon.recvRespRetry();
}
+ bool tryTiming(PacketPtr pkt)
+ {
+ return mon.tryTiming(pkt);
+ }
+
private:
CommMonitor& mon;
@@ -269,6 +274,8 @@
void recvRangeChange();
+ bool tryTiming(PacketPtr pkt);
+
/** Stats declarations, all in a struct for convenience. */
struct MonitorStats
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15736
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I86810170e5e10a0c5d63af76fc4a6ab70710d2fb
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev