Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/44987 )

Change subject: base: Mark the unused DPRINTF_UNCONDITIONAL macro as deprecated.
......................................................................

base: Mark the unused DPRINTF_UNCONDITIONAL macro as deprecated.

Change-Id: I9443051034c58efa223a69eefa20037068ae3e1c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44987
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
---
M src/base/trace.hh
1 file changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/trace.hh b/src/base/trace.hh
index be8476b..8796d8a 100644
--- a/src/base/trace.hh
+++ b/src/base/trace.hh
@@ -167,7 +167,7 @@
  * \def DPRINTFV(x, ...)
  * \def DPRINTFN(...)
  * \def DPRINTFNR(...)
- * \def DPRINTF_UNCONDITIONAL(x, ...)
+ * \def DPRINTF_UNCONDITIONAL(x, ...) (deprecated)
  *
  * @ingroup api_trace
  * @{
@@ -217,10 +217,12 @@
Trace::getDebugLogger()->dprintf((Tick)-1, std::string(), __VA_ARGS__); \
 } while (0)

-#define DPRINTF_UNCONDITIONAL(x, ...) do {    \
-    Trace::getDebugLogger()->dprintf_flag(    \
+#define DPRINTF_UNCONDITIONAL(x, ...) \
+    GEM5_DEPRECATED_MACRO_STMT(DPRINTF_UNCONDITIONAL, \
+    do { Trace::getDebugLogger()->dprintf_flag(    \
         curTick(), name(), #x, __VA_ARGS__);  \
-} while (0)
+    } while (0), \
+    "Use DPRINTFN or DPRINTF with a debug flag instead.")

 #else // !TRACING_ON

@@ -231,7 +233,9 @@
 #define DPRINTFV(...) do {} while (0)
 #define DPRINTFN(...) do {} while (0)
 #define DPRINTFNR(...) do {} while (0)
-#define DPRINTF_UNCONDITIONAL(x, ...) do {} while (0)
+#define DPRINTF_UNCONDITIONAL(x, ...) \
+    GEM5_DEPRECATED_MACRO_STMT(DPRINTF_UNCONDITIONAL, do {} while (0), \
+    "Use DPRINTFN or DPRINTF with a debug flag instead.")

 #endif  // TRACING_ON




6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44987
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9443051034c58efa223a69eefa20037068ae3e1c
Gerrit-Change-Number: 44987
Gerrit-PatchSet: 8
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to