Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/43005 )
Change subject: base-stats: Remove SimObject dependency from stats group
......................................................................
base-stats: Remove SimObject dependency from stats group
Remove this circular dependency by casting to Named
instead of SimObject.
Change-Id: I1054562750ba30d3ad4f9e2fbe238fd6fe2d4cb0
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/43005
Tested-by: kokoro <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
---
M src/base/stats/group.cc
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/stats/group.cc b/src/base/stats/group.cc
index 3d7aa01..675638c 100644
--- a/src/base/stats/group.cc
+++ b/src/base/stats/group.cc
@@ -39,10 +39,10 @@
#include "base/compiler.hh"
#include "base/logging.hh"
+#include "base/named.hh"
#include "base/stats/info.hh"
#include "base/trace.hh"
#include "debug/Stats.hh"
-#include "sim/sim_object.hh"
GEM5_DEPRECATED_NAMESPACE(Stats, statistics);
namespace statistics
@@ -70,10 +70,9 @@
for (auto &g : statGroups) {
if (Debug::Stats) {
- GEM5_VAR_USED const SimObject *so =
- dynamic_cast<const SimObject *>(this);
+ M5_VAR_USED const Named *named = dynamic_cast<const Named
*>(this);
DPRINTF(Stats, "%s: regStats in group %s\n",
- so ? so->name() : "?",
+ named ? named->name() : "?",
g.first);
}
g.second->regStats();
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43005
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I1054562750ba30d3ad4f9e2fbe238fd6fe2d4cb0
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 12
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s