Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/46626 )
Change subject: tests: Re-enable the realview-o3-checker test
......................................................................
tests: Re-enable the realview-o3-checker test
We are using the VExpress_GEM5_V1 platform for this test.
This is currently needed as the checker is GICv3 incompatible:
When validating MiscReg cpu interface register (MISCREG_ICC_*) updates
the underlying ISA storage is checked. However the content of some of
those registers is hardcoded in the GICv3 logic
JIRA: https://gem5.atlassian.net/browse/GEM5-364
Signed-off-by: Giacomo Travaglini <[email protected]>
Change-Id: I8cfbba6d9869232fdb8475d17d15d15b61dfab87
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46626
Tested-by: kokoro <[email protected]>
Reviewed-by: Richard Cooper <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M tests/gem5/configs/realview64-o3-checker.py
M tests/gem5/fs/linux/arm/test.py
2 files changed, 4 insertions(+), 6 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Richard Cooper: Looks good to me, but someone else must approve
kokoro: Regressions pass
diff --git a/tests/gem5/configs/realview64-o3-checker.py
b/tests/gem5/configs/realview64-o3-checker.py
index 9862818..ffbb7c6 100644
--- a/tests/gem5/configs/realview64-o3-checker.py
+++ b/tests/gem5/configs/realview64-o3-checker.py
@@ -38,6 +38,7 @@
from common.cores.arm.O3_ARM_v7a import O3_ARM_v7a_3
root = LinuxArmFSSystemUniprocessor(mem_mode='timing',
+ machine_type='VExpress_GEM5_V1',
mem_class=DDR3_1600_8x8,
cpu_class=O3_ARM_v7a_3,
checker=True).create_root()
diff --git a/tests/gem5/fs/linux/arm/test.py
b/tests/gem5/fs/linux/arm/test.py
index bf9f517..5b64c80 100644
--- a/tests/gem5/fs/linux/arm/test.py
+++ b/tests/gem5/fs/linux/arm/test.py
@@ -70,6 +70,7 @@
'realview-switcheroo-o3',
'realview-switcheroo-full',
'realview64-o3',
+ 'realview64-o3-checker',
'realview64-o3-dual',
'realview64-minor',
'realview64-minor-dual',
@@ -80,8 +81,8 @@
'realview64-simple-timing-dual-ruby',
- # The following tests fail. These are recorded in the GEM5-640 and
GEM5-364
- # Jira issues.
+ # The following tests fail. These are recorded in the GEM5-640
+ # Jira issue.
#
# https://gem5.atlassian.net/browse/GEM5-640
#'realview-simple-atomic-dual',
@@ -89,10 +90,6 @@
#'realview-o3-dual',
#'realview-minor-dual',
#'realview-simple-timing-dual-ruby',
- #
- # https://gem5.atlassian.net/browse/GEM5-364
- #'realview-o3-checker',
- #'realview64-o3-checker',
]
tarball = 'aarch-system-20210904.tar.bz2'
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46626
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8cfbba6d9869232fdb8475d17d15d15b61dfab87
Gerrit-Change-Number: 46626
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Richard Cooper <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s