Jan Vrany has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/48185 )
Change subject: base: Remove unused ConnectEvent from BaseRemoteGDB
......................................................................
base: Remove unused ConnectEvent from BaseRemoteGDB
There's no need for such event since connect() is called explicitly
in workflow's startup.
Change-Id: If0e9f344f0ef2a46df783041438e6c424ed94293
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc
index 76541d9..a257916 100644
--- a/src/base/remote_gdb.cc
+++ b/src/base/remote_gdb.cc
@@ -354,13 +354,12 @@
}
BaseRemoteGDB::BaseRemoteGDB(System *_system, int _port) :
- connectEvent(nullptr), dataEvent(nullptr), _port(_port), fd(-1),
+ dataEvent(nullptr), _port(_port), fd(-1),
sys(_system), trapEvent(this), singleStepEvent(*this)
{}
BaseRemoteGDB::~BaseRemoteGDB()
{
- delete connectEvent;
delete dataEvent;
}
@@ -385,9 +384,6 @@
DPRINTF(GDBMisc, "Can't bind port %d\n", _port);
_port++;
}
-
- connectEvent = new ConnectEvent(this, listener.getfd(), POLLIN);
- pollQueue.schedule(connectEvent);
}
void
diff --git a/src/base/remote_gdb.hh b/src/base/remote_gdb.hh
index dbf3774..962d2fb 100644
--- a/src/base/remote_gdb.hh
+++ b/src/base/remote_gdb.hh
@@ -191,7 +191,6 @@
* Connection to the external GDB.
*/
void incomingData(int revent);
- void connectWrapper(int revent) { connect(); }
template <void (BaseRemoteGDB::*F)(int revent)>
class SocketEvent : public PollEvent
@@ -207,13 +206,10 @@
void process(int revent) { (gdb->*F)(revent); }
};
- typedef SocketEvent<&BaseRemoteGDB::connectWrapper> ConnectEvent;
typedef SocketEvent<&BaseRemoteGDB::incomingData> DataEvent;
- friend ConnectEvent;
friend DataEvent;
- ConnectEvent *connectEvent;
DataEvent *dataEvent;
ListenSocket listener;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48185
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If0e9f344f0ef2a46df783041438e6c424ed94293
Gerrit-Change-Number: 48185
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Vrany <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s