Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/51050 )
Change subject: sim-se: Implemnt fchownat syscall
......................................................................
sim-se: Implemnt fchownat syscall
JIRA: https://gem5.atlassian.net/browse/GEM5-1098
Change-Id: I46f9a5ba30a27c29a8a50323a0fb95074016ddb2
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51050
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/sim/syscall_emul.cc
M src/sim/syscall_emul.hh
2 files changed, 46 insertions(+), 2 deletions(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/syscall_emul.cc b/src/sim/syscall_emul.cc
index 2f73800..3a732c0 100644
--- a/src/sim/syscall_emul.cc
+++ b/src/sim/syscall_emul.cc
@@ -657,11 +657,18 @@
VPtr<> pathname, uint32_t owner, uint32_t group)
{
std::string path;
- auto p = tc->getProcessPtr();
-
if (!SETranslatingPortProxy(tc).tryReadString(path, pathname))
return -EFAULT;
+ return chownImpl(desc, tc, path, owner, group);
+}
+
+SyscallReturn
+chownImpl(SyscallDesc *desc, ThreadContext *tc,
+ std::string path, uint32_t owner, uint32_t group)
+{
+ auto p = tc->getProcessPtr();
+
/* XXX endianess */
uid_t hostOwner = owner;
gid_t hostGroup = group;
diff --git a/src/sim/syscall_emul.hh b/src/sim/syscall_emul.hh
index a7a7baf..e46f059 100644
--- a/src/sim/syscall_emul.hh
+++ b/src/sim/syscall_emul.hh
@@ -256,6 +256,8 @@
/// Target chown() handler.
SyscallReturn chownFunc(SyscallDesc *desc, ThreadContext *tc,
VPtr<> pathname, uint32_t owner, uint32_t group);
+SyscallReturn chownImpl(SyscallDesc *desc, ThreadContext *tc,
+ std::string path, uint32_t owner, uint32_t group);
/// Target getpgrpFunc() handler.
SyscallReturn getpgrpFunc(SyscallDesc *desc, ThreadContext *tc);
@@ -1019,6 +1021,25 @@
return renameImpl(desc, tc, old_name, new_name);
}
+/// Target fchownat() handler
+template <class OS>
+SyscallReturn
+fchownatFunc(SyscallDesc *desc, ThreadContext *tc,
+ int dirfd, VPtr<> pathname, uint32_t owner, uint32_t group,
+ int flags)
+{
+ std::string path;
+ if (!SETranslatingPortProxy(tc).tryReadString(path, pathname))
+ return -EFAULT;
+
+ // Modifying path from the directory descriptor
+ if (auto res = atSyscallPath<OS>(tc, dirfd, path); !res.successful()) {
+ return res;
+ }
+
+ return chownImpl(desc, tc, path, owner, group);
+}
+
/// Target sysinfo() handler.
template <class OS>
SyscallReturn
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51050
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I46f9a5ba30a27c29a8a50323a0fb95074016ddb2
Gerrit-Change-Number: 51050
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Richard Cooper <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s