Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/51056 )
Change subject: sim-se: Implement mknodat syscall
......................................................................
sim-se: Implement mknodat syscall
JIRA: https://gem5.atlassian.net/browse/GEM5-1098
Change-Id: Ic6b6b9350bcffdaed368373a6bffe4f9ece5feee
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51056
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
---
M src/sim/syscall_emul.cc
M src/sim/syscall_emul.hh
2 files changed, 44 insertions(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/syscall_emul.cc b/src/sim/syscall_emul.cc
index 28a1126..c212d24 100644
--- a/src/sim/syscall_emul.cc
+++ b/src/sim/syscall_emul.cc
@@ -928,11 +928,18 @@
mknodFunc(SyscallDesc *desc, ThreadContext *tc,
VPtr<> pathname, mode_t mode, dev_t dev)
{
- auto p = tc->getProcessPtr();
std::string path;
if (!SETranslatingPortProxy(tc).tryReadString(path, pathname))
return -EFAULT;
+ return mknodImpl(desc, tc, path, mode, dev);
+}
+
+SyscallReturn
+mknodImpl(SyscallDesc *desc, ThreadContext *tc,
+ std::string path, mode_t mode, dev_t dev)
+{
+ auto p = tc->getProcessPtr();
path = p->checkPathRedirect(path);
auto result = mknod(path.c_str(), mode, dev);
diff --git a/src/sim/syscall_emul.hh b/src/sim/syscall_emul.hh
index fb3bf85..0f27cb2 100644
--- a/src/sim/syscall_emul.hh
+++ b/src/sim/syscall_emul.hh
@@ -203,6 +203,8 @@
/// Target mknod() handler.
SyscallReturn mknodFunc(SyscallDesc *desc, ThreadContext *tc,
VPtr<> pathname, mode_t mode, dev_t dev);
+SyscallReturn mknodImpl(SyscallDesc *desc, ThreadContext *tc,
+ std::string path, mode_t mode, dev_t dev);
/// Target chdir() handler.
SyscallReturn chdirFunc(SyscallDesc *desc, ThreadContext *tc, VPtr<>
pathname);
@@ -1092,6 +1094,24 @@
return mkdirImpl(desc, tc, path, mode);
}
+/// Target mknodat() handler
+template <class OS>
+SyscallReturn
+mknodatFunc(SyscallDesc *desc, ThreadContext *tc,
+ int dirfd, VPtr<> pathname, mode_t mode, dev_t dev)
+{
+ std::string path;
+ if (!SETranslatingPortProxy(tc).tryReadString(path, pathname))
+ return -EFAULT;
+
+ // Modifying path from the directory descriptor
+ if (auto res = atSyscallPath<OS>(tc, dirfd, path); !res.successful()) {
+ return res;
+ }
+
+ return mknodImpl(desc, tc, path, mode, dev);
+}
+
/// Target sysinfo() handler.
template <class OS>
SyscallReturn
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51056
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic6b6b9350bcffdaed368373a6bffe4f9ece5feee
Gerrit-Change-Number: 51056
Gerrit-PatchSet: 5
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Richard Cooper <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s