----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/754/#review1355 -----------------------------------------------------------
Ship it! What email do you want to use for the commit message? - Korey On 2011-06-21 18:45:58, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/754/ > ----------------------------------------------------------- > > (Updated 2011-06-21 18:45:58) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > In the official MIPS ISA documents, the nmadd/nmsub means "multiply, > add/subtract, then negtive". > In the earlier version, the code of nmsub_s is "Fd.sf = -1 * ((Fs.sf * Ft.sf) > - Fr.sf);", but the brackets have been changed now. > So change the sign here. > > > Diffs > ----- > > src/arch/mips/isa/decoder.isa 00766f5b8177 > > Diff: http://reviews.m5sim.org/r/754/diff > > > Testing > ------- > > Compare with the gem5 stable version and MIPS ISA official documents. > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
