----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/776/#review1408 -----------------------------------------------------------
Is it necessary for the fault model to be configured using a text file? Can you do this in python instead? For instance, if you used scripts to generate the files, it would be best if you implemented those scripts in python and used the standard sim_object methodology. Also is the one text file just a "temp" file? If so, should it be checked it? - Brad On 2011-07-08 17:46:10, Konstantinos Aisopos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/776/ > ----------------------------------------------------------- > > (Updated 2011-07-08 17:46:10) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, Brad Beckmann, and Tushar Krishna. > > > Summary > ------- > > GARNET: adding a fault model for resilient on-chip network research. > > This patch adds a fault model, which provides the probability for a number of > architectural faults in the interconnection network (e.g., data corruption, > misrouting). These probabilities can be used to realistically inject faults > in GARNET and faithfully evaluate the effectiveness of novel resilient NoC > architectures. > > > Diffs > ----- > > src/mem/ruby/network/fault_model/DB.conf.txt PRE-CREATION > src/mem/ruby/network/fault_model/DB.temp.txt PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.hh PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.cc PRE-CREATION > src/mem/ruby/network/fault_model/README PRE-CREATION > src/mem/ruby/network/fault_model/SConscript PRE-CREATION > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 7907b19fbe80 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 7907b19fbe80 > src/mem/ruby/network/garnet/BaseGarnetNetwork.py 7907b19fbe80 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 7907b19fbe80 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 7907b19fbe80 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 7907b19fbe80 > > Diff: http://reviews.m5sim.org/r/776/diff > > > Testing > ------- > > > Thanks, > > Konstantinos > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
