> Yea, that crossed my mind, but we're not very consistent about attibute
> names ('ip' in this case, 'value' most often, but sometimes 'val'), so it's
> hard to know what to do in ParamValue.
We should definitely standardize. The whole mechanism for getting the
value is a bit rough. Probably because of proxying stuff.
> We could define a __cmp__ on NumericParamValue though, and that would cover
> a lot of ground.
Sounds like a good plan to me.
> Another thing I considered is that we might want to switch a lot of the
> ini_str() implementations to __str__(). The default for ini_str() is
> str(self), and then you get prettier printing when debugging as well as in
> the config.ini file.
> There's also one case (Time) that has a redundant ini_str() definition that
> matches the ParamValue default.
I'd be all for using __str__. I think that the ini_str() is a hold
over from when we actually parsed the ini file and we needed to output
in a format that we could suck back in with the builder stuff. Now
that the ini file is just diagnostic, I see no reason to care about
that.
I don't know if you have time to do it, but I'll happily review a diff
in this area :)
Nate
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
