----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/806/#review1440 -----------------------------------------------------------
src/cpu/o3/O3CPU.py <http://reviews.m5sim.org/r/806/#comment1866> This param name seems vague and underdescriptive... how about storeset_reset_period or storeset_clear_interval or something like that? Otherwise it looks good... - Steve On 2011-07-26 21:32:42, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/806/ > ----------------------------------------------------------- > > (Updated 2011-07-26 21:32:42) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > LSQ: Set store predictor to periodically clear itself as recommended in the > storesets paper. > > This patch improves performance by as much as 10% on some spec benchmarks. > > > Diffs > ----- > > src/cpu/o3/O3CPU.py 7f49e6a176b8 > src/cpu/o3/mem_dep_unit_impl.hh 7f49e6a176b8 > src/cpu/o3/store_set.hh 7f49e6a176b8 > src/cpu/o3/store_set.cc 7f49e6a176b8 > > Diff: http://reviews.m5sim.org/r/806/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
