> On 2011-07-27 12:07:33, Nathan Binkert wrote: > > src/mem/slicc/symbols/Func.py, line 66 > > <http://reviews.m5sim.org/r/809/diff/1/?file=13475#file13475line66> > > > > Should this function exist? Is it still called? I'd think that you > > could remove this now. > > Nilay Vaish wrote: > Nate, when I remove it, python complains that 'Func' object has no > attribute > 'writeCodeFiles'. I looked in to SymbolTable.py and writeCodeFiles() is > called > on all the symbols. Should not that mean that Func class should have > writeCodeFiles() > defined? Similarly Var.py also has a writeCodeFiles() function which does > nothing. > > Nathan Binkert wrote: > I guess if Var is done the same way, then we can keep it. We can clean > this up in the future. (FYI, I doubt that this has a noticeable impact on > compile time).
I took only one time measure and that too without the -j option. The difference was about 20s. I think with -j, there would be negligible impact. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/809/#review1439 ----------------------------------------------------------- On 2011-07-26 09:06:26, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/809/ > ----------------------------------------------------------- > > (Updated 2011-07-26 09:06:26) > > > Review request for Default. > > > Summary > ------- > > SLICC: Put functions of a controller in its .cc file > Currently, functions associated with a controller go into separate files. > This patch puts all the functions in the controller's .cc file. This should > hopefully take away some time from compilation. > > > Diffs > ----- > > src/mem/slicc/ast/FuncDeclAST.py eb82084f1f4f > src/mem/slicc/symbols/Func.py eb82084f1f4f > src/mem/slicc/symbols/StateMachine.py eb82084f1f4f > > Diff: http://reviews.m5sim.org/r/809/diff > > > Testing > ------- > > Compiles cleanly. > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
