Yea.. I deleted it. While ti did fix a couple use after deletes and some memory leaks it also created a memory leak when certain kinds of writebacks happened that I didn't run into until running o3 for a couple of hours. I'll submit some of the fixes as a new patch and try and figure out what's going on in the caches, but I think I'm going to have some questions.
Thanks, Ali On Jul 27, 2011, at 4:03 PM, Steve Reinhardt wrote: > I get an error when I try to view this... did you cancel it? > > On Tue, Jul 26, 2011 at 8:50 AM, Ali Saidi <[email protected]> wrote: > >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/805/ >> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >> Nathan Binkert. >> By Ali Saidi. >> Description >> >> Mem: Fix a use after delete and memory leaks with the prefetcher. >> >> Diffs >> >> - src/mem/cache/cache_impl.hh (7f49e6a176b8) >> - src/mem/cache/prefetch/base.cc (7f49e6a176b8) >> >> View Diff <http://reviews.m5sim.org/r/805/diff/> >> > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
