----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/776/#review1460 -----------------------------------------------------------
Thanks for the update. This is much cleaner! My only major comment is be consistent with your spacing between operators and operands. I only identified a couple of lines where there should be spaces, but there are many other lines that need spacing. Other than that and one more minor question below, this patch looks good to me. src/mem/ruby/network/fault_model/FaultModel.cc <http://reviews.m5sim.org/r/776/#comment1878> Why 12? If this is a constant, please use a const int or define a macro. Also please add a space between math operators and operands: ex" "int i = 0;" src/mem/ruby/network/fault_model/FaultModel.cc <http://reviews.m5sim.org/r/776/#comment1879> Spacing here too... Ex. "number_of_inputs <= 0" src/mem/ruby/network/garnet/BaseGarnetNetwork.py <http://reviews.m5sim.org/r/776/#comment1880> If the fault model only works with the fixed network, shouldn't these parameters be moved to the fixed network python class and not the base network class? - Brad On 2011-08-10 14:46:31, Konstantinos Aisopos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/776/ > ----------------------------------------------------------- > > (Updated 2011-08-10 14:46:31) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, Brad Beckmann, and Tushar Krishna. > > > Summary > ------- > > GARNET: adding a fault model for resilient on-chip network research. > > This patch adds a fault model, which provides the probability of a number of > architectural faults in the interconnection network (e.g., data corruption, > misrouting). These probabilities can be used to realistically inject faults > in GARNET and faithfully evaluate the effectiveness of novel resilient NoC > architectures. > > > Diffs > ----- > > configs/ruby/Ruby.py 22a15643e2ca > src/mem/ruby/network/fault_model/FaultModel.hh PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.cc PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.py PRE-CREATION > src/mem/ruby/network/fault_model/SConscript PRE-CREATION > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 22a15643e2ca > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 22a15643e2ca > src/mem/ruby/network/garnet/BaseGarnetNetwork.py 22a15643e2ca > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 22a15643e2ca > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 22a15643e2ca > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 22a15643e2ca > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 22a15643e2ca > > Diff: http://reviews.m5sim.org/r/776/diff > > > Testing > ------- > > > Thanks, > > Konstantinos > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
