----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/847/#review1515 -----------------------------------------------------------
Adding the new accessor should be its own change since it and the rest are doing different things, even though it's small and there's a dependency. Otherwise this looks good to me. - Gabe On 2011-09-09 14:57:38, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/847/ > ----------------------------------------------------------- > > (Updated 2011-09-09 14:57:38) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: update TLB to set request packet ASID field > > Add a setAsid() method on the request and update the request asid during TLB > translation from the ARM contextidr register. > > > Diffs > ----- > > src/arch/arm/miscregs.hh 1f95c9a0bb2f > src/arch/arm/tlb.hh 1f95c9a0bb2f > src/arch/arm/tlb.cc 1f95c9a0bb2f > src/mem/request.hh 1f95c9a0bb2f > > Diff: http://reviews.m5sim.org/r/847/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
