----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/852/#review1518 -----------------------------------------------------------
Ship it! - Ali On 2011-09-10 03:13:05, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/852/ > ----------------------------------------------------------- > > (Updated 2011-09-10 03:13:05) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > X86: Don't use "#if FULL_SYSTEM" in the X86 ISA description. > > The decoder now checks the value of FULL_SYSTEM in a switch statement to > decide whether to return a real syscall instruction or one that triggers > syscall emulation (or a panic in FS mode). The switch statement should devolve > into an if, and also should be optimized out since it's based on constant > input. > > > Diffs > ----- > > src/arch/x86/isa/decoder/one_byte_opcodes.isa 9678812ccb62 > src/arch/x86/isa/decoder/two_byte_opcodes.isa 9678812ccb62 > > Diff: http://reviews.m5sim.org/r/852/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
