----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/820/#review1530 -----------------------------------------------------------
src/dev/ide_ctrl.cc <http://reviews.m5sim.org/r/820/#comment2033> need braces here and below per style guide (at least I thought that was in the style guide...) src/dev/ide_disk.cc <http://reviews.m5sim.org/r/820/#comment2034> is this a whitespace change? src/dev/ide_disk.cc <http://reviews.m5sim.org/r/820/#comment2035> seems odd to add a new dprintf here that's identical to (but not control-exclusive with) the one below - Steve On 2011-08-09 12:33:35, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/820/ > ----------------------------------------------------------- > > (Updated 2011-08-09 12:33:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IDE: Fix issues with new PIIX kernel driver and our model. > > The driver can read the IDE config register as a 32 bit register since > some adapters use bit 18 as a disable channel bit. If the size isn't > set in a PRD it should be 64K according to the SPEC (and driver) not > 128K. > > > Diffs > ----- > > src/dev/ide_ctrl.cc 7f49e6a176b8 > src/dev/ide_disk.hh 7f49e6a176b8 > src/dev/ide_disk.cc 7f49e6a176b8 > > Diff: http://reviews.m5sim.org/r/820/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
