> On 2011-09-12 09:19:08, Steve Reinhardt wrote: > > I assume these are ISA-independent, right? If so, it would be nice to have > > Makefile support not isolated to ARM. Ideally it would be nice to have a > > common makefile structure with only the parts that differ factored out, in > > which case this request would be trivial. > > > > I don't mean to snowball this simple change into a requirement to > > rearchitect the whole makefile structure here, just pointing out that it's > > the Right Thing To Do. If you want to commit this as it, I won't protest, > > I'll just be disappointed ;-) > > Steve Reinhardt wrote: > I also should mention that the nice little example you have in the commit > message really belongs as a comment in the code, not in the commit message... > we need to keep in mind that users are not going to search the hg log for > documentation (nor should they be expected to) > > Ali Saidi wrote: > I moved the example into the wiki. > > As for the Makefile, I think Gabe had some changes to use scons to build > them. > > Gabe Black wrote: > Nope, although I could do that if that's useful. I think you're thinking > of statetrace.
I'll take a look at the makefile differences - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/831/#review1532 ----------------------------------------------------------- On 2011-08-19 15:27:51, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/831/ > ----------------------------------------------------------- > > (Updated 2011-08-19 15:27:51) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > gem5ops: Implement Java JNI for gem5Ops > > These ops allow gem5 ops to be called from within java programs like the > following: > import jni.gem5Op; > > public class HelloWorld { > > public static void main(String[] args) { > gem5Op gem5 = new gem5Op(); > System.out.println("Rpns0:" + gem5.rpns()); > System.out.println("Rpns1:" + gem5.rpns()); > } > > static { > System.loadLibrary("gem5OpJni"); > } > } > > When building you need to make sure classpath include gem5OpJni.jar: > javac -classpath $CLASSPATH:/path/to/gem5OpJni.jar HelloWorld.java > > and when running you need to make sure both the java and library path are set: > java -classpath $CLASSPATH:/path/to/gem5OpJni.jar > -Djava.library.path=/path/to/libgem5OpJni.so HelloWorld > > > Diffs > ----- > > util/m5/Makefile.arm 1f95c9a0bb2f > util/m5/jni/gem5Op.java PRE-CREATION > util/m5/jni_gem5Op.c PRE-CREATION > > Diff: http://reviews.m5sim.org/r/831/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
