----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/875/#review1563 -----------------------------------------------------------
Ship it! Looks good. Comment is just a suggestion. src/arch/SConscript <http://reviews.m5sim.org/r/875/#comment2050> Be nice to have a comment here like: # skip isa_parser in source[1] ...though that makes me wonder what's in source[0]... is that the ISA desc input itself? - Steve On 2011-09-24 03:32:22, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/875/ > ----------------------------------------------------------- > > (Updated 2011-09-24 03:32:22) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SCons: Make the ISA parser a source for its output files like the comments > say. > > There was a change a while ago that refactored some scons stuff which got rid > of cpu_models.py but also accidentally got rid of the ISA parser as a source > for its target files. That meant that changes which affected the parser > wouldn't cause a rebuild unless they also changed one of the description > files. This change fixes that. > > > Diffs > ----- > > src/arch/SConscript dd79a696b91c > > Diff: http://reviews.m5sim.org/r/875/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
