----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/878/#review1571 -----------------------------------------------------------
Make sure that you don't run afoul of the problem in changeset c6e283904437. We used to have something like this, but I undid it because it broke older versions of swig. You have a different approach here, but I'd hate to have you reintroduce a bug. - Nathan On 2011-09-24 09:51:34, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/878/ > ----------------------------------------------------------- > > (Updated 2011-09-24 09:51:34) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > swig: move all swigged objects into m5.internal.swig package > > SWIG-generated packages for params, enums, wrapped C++ SimObjects, > etc. were being generated directly into m5.internal, with some > funky code to import some of the declarations into m5.internal.params. > Moved all generated packages under m5.internal.swig and imported > things directly from there where necessary. Cleaned up some > exposed loose ends. Turns out m5.internal.params doesn't really seem > to be needed, so it's gone now. > > Also renamed param_Foo packages that wrap both the C++ version of > Foo and FooParams to just Foo; now that they're under a separate > subpackage there's no ambiguity with the primary Python objects, > and no need to have the param_ prefix to support the funky > importing into internal.params. > > > Diffs > ----- > > src/SConscript d182a475a668 > src/python/SConscript d182a475a668 > src/python/m5/SimObject.py d182a475a668 > src/python/m5/internal/params.py d182a475a668 > src/python/m5/internal/swig/__init__.py PRE-CREATION > src/python/m5/objects/__init__.py d182a475a668 > src/python/m5/params.py d182a475a668 > src/python/swig/inet.i d182a475a668 > src/python/swig/time.i d182a475a668 > > Diff: http://reviews.m5sim.org/r/878/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
