----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/876/#review1580 -----------------------------------------------------------
Ship it! Overall, I like where this is going. Too much code moved for me to give this a very thorough review, but I did a bunch of checking and I didn't notice any issues. src/python/m5/SimObject.py <http://reviews.m5sim.org/r/876/#comment2058> I asume that this works because classmethod is a "public_value"? - Nathan On 2011-09-24 09:49:10, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/876/ > ----------------------------------------------------------- > > (Updated 2011-09-24 09:49:10) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > scons/swig: refactor some of the scons/SWIG code > > - Move the random bits of SWIG code generation out of src/SConscript > file and into methods on the objects being wrapped. > - Cleaned up some variable naming and added some comments to make > the process a little clearer. > - Did a little generated file/module renaming: > - vptype_Foo now Foo_vector > - init_Foo is now Foo_init > This makes it easier to see all the Foo-related files in a > sorted directory listing. > - Made cxx_predecls and swig_predecls normal SimObject classmethods. > - Got rid of swig_objdecls hook, even though this breaks the System > objects get/setMemoryMode method exports. Will be fixing this in > a future changeset. > > > Diffs > ----- > > src/SConscript d182a475a668 > src/python/m5/SimObject.py d182a475a668 > src/python/m5/params.py d182a475a668 > src/sim/System.py d182a475a668 > > Diff: http://reviews.m5sim.org/r/876/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
