> On 2011-09-25 20:43:27, Nathan Binkert wrote: > > I'm ambivalent about this change. What I'd really rather see is that we > > just wrap all sim objects and use #ifndef SWIG for the parts that cause us > > problems.
Yea, that sounds nice in theory, but I'm scared to try it in practice... just seems like it could be a real rathole of figuring out what to #ifdef and what to let swig chew on. IMO this is a definite improvement over the current method though. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/877/#review1581 ----------------------------------------------------------- On 2011-09-24 09:51:23, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/877/ > ----------------------------------------------------------- > > (Updated 2011-09-24 09:51:23) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SimObject: add export_method* hooks to export C++ methods to Python > > Replace the (broken as of previous changeset) swig_objdecl() method > that allowed/forced you to substitute a whole new C++ struct > definition for SWIG to wrap with a set of export_method* hooks > that let you just declare a set of C++ methods (or other declarations) > that get inserted in the auto-generated struct. > > Restore the System get/setMemoryMode methods, and use this mechanism > to specialize SimObject as well, eliminating teh need for sim_object.i. > Needed bits of sim_object.i are moved to the new pyobject.i. > Also sucked a little SimObject specialization into cxx_param_decl() > allowing us to get rid of src/sim/sim_object_params.hh. Now the > generation and wrapping of the base SimObject param struct is more > in line with how derived objects are handled. > > > Diffs > ----- > > src/python/SConscript d182a475a668 > src/python/m5/SimObject.py d182a475a668 > src/python/m5/params.py d182a475a668 > src/python/swig/pyobject.i PRE-CREATION > src/python/swig/sim_object.i d182a475a668 > src/python/swig/system.i d182a475a668 > src/sim/System.py d182a475a668 > src/sim/sim_object_params.hh d182a475a668 > > Diff: http://reviews.m5sim.org/r/877/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
