> On 2011-09-26 02:23:29, Ali Saidi wrote: > > Looks fine; although if i was being a stickler I would say that the dprintf > > change should go in a different change set.
You're right. I'll split it out when I commit. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/881/#review1585 ----------------------------------------------------------- On 2011-09-24 18:09:29, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/881/ > ----------------------------------------------------------- > > (Updated 2011-09-24 18:09:29) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Faults: Replace calls to genMachineCheckFault with M5PanicFault. > > > Diffs > ----- > > src/arch/alpha/faults.hh e21224136182 > src/arch/alpha/tlb.cc e21224136182 > src/arch/arm/faults.hh e21224136182 > src/arch/mips/faults.hh e21224136182 > src/arch/power/faults.hh e21224136182 > src/arch/sparc/faults.hh e21224136182 > src/arch/x86/faults.hh e21224136182 > src/cpu/o3/lsq_unit.hh e21224136182 > src/cpu/o3/lsq_unit_impl.hh e21224136182 > > Diff: http://reviews.m5sim.org/r/881/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
