----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/896/ -----------------------------------------------------------
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary ------- SE: move page allocation from PageTable to Process PageTable supported an allocate() call that called back through the Process to allocate memory, but did not have a method to map addresses without allocating new pages. It makes more sense for Process to do the allocation, so this method was renamed allocateMem() and moved to Process, and uses a new map() call on PageTable. The remaining uses of the process pointer in PageTable were only to get the name and the PID, so by passing these in directly in the constructor, we can make PageTable completely independent of Process. Diffs ----- src/arch/alpha/process.cc c7fec2cb91cb src/arch/arm/linux/process.cc c7fec2cb91cb src/arch/arm/process.cc c7fec2cb91cb src/arch/mips/process.cc c7fec2cb91cb src/arch/power/process.cc c7fec2cb91cb src/arch/sparc/process.cc c7fec2cb91cb src/arch/x86/process.cc c7fec2cb91cb src/kern/tru64/tru64.hh c7fec2cb91cb src/mem/page_table.hh c7fec2cb91cb src/mem/page_table.cc c7fec2cb91cb src/mem/translating_port.cc c7fec2cb91cb src/sim/process.hh c7fec2cb91cb src/sim/process.cc c7fec2cb91cb src/sim/syscall_emul.hh c7fec2cb91cb src/sim/syscall_emul.cc c7fec2cb91cb src/sim/system.hh c7fec2cb91cb src/sim/system.cc c7fec2cb91cb Diff: http://reviews.m5sim.org/r/896/diff Testing ------- Thanks, Steve _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
