----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/895/#review1617 -----------------------------------------------------------
This seems mostly reasonable and useful, but the goto really, really needs to go. src/mem/page_table.cc <http://reviews.m5sim.org/r/895/#comment2103> These brackets aren't really needed, although they aren't hurting anything. src/sim/syscall_emul.hh <http://reviews.m5sim.org/r/895/#comment2100> Long line? It's hard to tell in the browser. src/sim/syscall_emul.hh <http://reviews.m5sim.org/r/895/#comment2101> goto! Yikes! This needs to go! It makes the flow of this function hard to follow, and I'm sure it's not doing the compiler any favors. - Gabe On 2011-10-21 07:53:37, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/895/ > ----------------------------------------------------------- > > (Updated 2011-10-21 07:53:37) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > syscall_emul: implement MAP_FIXED option to mmap() > > > Diffs > ----- > > src/arch/alpha/linux/linux.hh c7fec2cb91cb > src/arch/alpha/tru64/tru64.hh c7fec2cb91cb > src/arch/arm/linux/linux.hh c7fec2cb91cb > src/arch/mips/linux/linux.hh c7fec2cb91cb > src/arch/power/linux/linux.hh c7fec2cb91cb > src/arch/sparc/linux/linux.hh c7fec2cb91cb > src/arch/sparc/solaris/solaris.hh c7fec2cb91cb > src/arch/x86/linux/linux.hh c7fec2cb91cb > src/mem/page_table.hh c7fec2cb91cb > src/mem/page_table.cc c7fec2cb91cb > src/sim/syscall_emul.hh c7fec2cb91cb > > Diff: http://reviews.m5sim.org/r/895/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
